DomGarguilo commented on PR #4667: URL: https://github.com/apache/accumulo/pull/4667#issuecomment-2166783289
> Another approach, which may touch less files, would be to just track the start time in the Compactor itself vs in the FileCompactor. [FileCompactorRunnable.initialize](https://github.com/apache/accumulo/blob/2.1/server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java#L521) could return the start time and use it in the STARTED status message. That method is called [here](https://github.com/apache/accumulo/blob/2.1/server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java#L736) and most of the other status messages are sent from that method. The SUCCEEDED message is sent from FileCompactorRunnable, so the start time could be used there if it was a member variable of the object that was set by initialize. Just a thought. I think it seems like a good idea to track the time in `FileCompactorRunnable` but this seems to also imply that we keep track and send the start time of the compaction as opposed to the changes that I made that send the duration of the compaction at the time of the update. To me it seems to make sense to send the duration but I am not sure if you had a reason it should be the other way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
