keith-turner commented on PR #4667: URL: https://github.com/apache/accumulo/pull/4667#issuecomment-2166640558
> I haven't looked into it very much yet but it seems like using the new currentCompactionStartTime would more accurately represent the age of an active compaction. This would allow us to remove the other variable too. > >Any thoughts on this? Starting to track time in call() vs the constructor seems a bit better to me. It would need to be set before [this line in calls()](https://github.com/apache/accumulo/blob/751c549108aff51cf55d93861cc254b743d54e5a/server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java#L283) so that it is visible to the code that inspects running compactions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
