dlmarion commented on code in PR #4667:
URL: https://github.com/apache/accumulo/pull/4667#discussion_r1639858837
##########
server/compactor/src/test/java/org/apache/accumulo/compactor/CompactorTest.java:
##########
@@ -107,6 +108,11 @@ public AtomicReference<FileCompactor> getFileCompactor() {
return new AtomicReference<>(compactor);
}
+ @Override
+ public Duration getCompactionAge() {
Review Comment:
`toNanos` is called on the return value in almost all cases. I'm wondering
if you want to change this to `Duration.ZERO` to prevent a
`NullPointerException`. Same comment for the same change in
`ExternalDoNothingCompactor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
