kevinrr888 commented on code in PR #5547:
URL: https://github.com/apache/accumulo/pull/5547#discussion_r2116603967
##########
minicluster/src/test/java/org/apache/accumulo/miniclusterImpl/CleanShutdownMacTest.java:
##########
@@ -41,13 +41,15 @@
public class CleanShutdownMacTest extends WithTestNames {
@TempDir
- private static File tmpDir;
+ private static Path tmpDir;
@Test
public void testExecutorServiceShutdown() throws Exception {
- File tmp = tmpDir.toPath().resolve(testName()).toFile();
- assertTrue(tmp.isDirectory() || tmp.mkdir(), "Failed to make a new
sub-directory");
Review Comment:
might still be good to have a similar assertion:
`assertTrue(Files.isDirectory(dir))`
##########
server/base/src/test/java/org/apache/accumulo/server/conf/CheckCompactionConfigTest.java:
##########
@@ -168,13 +168,15 @@ public void testBadPropsFilePath() {
}
private String writeToFileAndReturnPath(String inputString) throws
IOException {
- File file = tempDir.toPath().resolve(testName() + ".properties").toFile();
- assertTrue(file.isFile() || file.createNewFile());
- try (BufferedWriter bufferedWriter =
Files.newBufferedWriter(file.toPath())) {
+ Path file = tempDir.resolve(testName() + ".properties");
+ if (!Files.isRegularFile(file)) {
+ Files.createFile(file);
+ }
Review Comment:
would be good to keep a similar assertion:
`assertTrue(Files.isDirectory(dir))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
