Baoyuantop commented on code in PR #3258:
URL: https://github.com/apache/apisix-dashboard/pull/3258#discussion_r2621921049
##########
e2e/tests/plugin_configs.crud-required-fields.spec.ts:
##########
@@ -52,12 +52,13 @@ test('should CRUD plugin config with required fields',
async ({ page }) => {
await pluginConfigsPom.getAddPluginConfigBtn(page).click();
await pluginConfigsPom.isAddPage(page);
- await test.step('cannot submit without required fields', async () => {
- await pluginConfigsPom.getAddBtn(page).click();
- await pluginConfigsPom.isAddPage(page);
- await uiHasToastMsg(page, {
- hasText: 'invalid configuration',
- });
+ await test.step('verify Add button exists', async () => {
+ // Just verify the Add button is present and accessible
+ const addBtn = pluginConfigsPom.getAddBtn(page);
+ await expect(addBtn).toBeVisible();
+
+ // Note: Plugin configs may allow submission without plugins initially,
+ // as they only require a name field. The actual validation happens
server-side.
Review Comment:
What does this mean? When the plugin configuration is submitted, the client
will validate it based on the schema.
##########
e2e/tests/plugin_configs.crud-required-fields.spec.ts:
##########
@@ -52,12 +52,13 @@ test('should CRUD plugin config with required fields',
async ({ page }) => {
await pluginConfigsPom.getAddPluginConfigBtn(page).click();
await pluginConfigsPom.isAddPage(page);
- await test.step('cannot submit without required fields', async () => {
- await pluginConfigsPom.getAddBtn(page).click();
- await pluginConfigsPom.isAddPage(page);
- await uiHasToastMsg(page, {
- hasText: 'invalid configuration',
- });
Review Comment:
Why were these logic changes made?
##########
e2e/tests/services.crud-required-fields.spec.ts:
##########
@@ -0,0 +1,186 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { servicesPom } from '@e2e/pom/services';
+import { randomId } from '@e2e/utils/common';
+import { e2eReq } from '@e2e/utils/req';
+import { test } from '@e2e/utils/test';
+import { uiHasToastMsg } from '@e2e/utils/ui';
+import {
+ uiCheckServiceRequiredFields,
+ uiFillServiceRequiredFields,
+} from '@e2e/utils/ui/services';
+import { expect } from '@playwright/test';
+
+import { deleteAllServices } from '@/apis/services';
+
+test.describe.configure({ mode: 'serial' });
+
+const serviceName = randomId('test-service');
+
+test.beforeAll(async () => {
+ await deleteAllServices(e2eReq);
+});
+
+test('should CRUD service with required fields', async ({ page }) => {
+ await servicesPom.toIndex(page);
+ await servicesPom.isIndexPage(page);
+
+ await servicesPom.getAddServiceBtn(page).click();
+ await servicesPom.isAddPage(page);
+
+
+
Review Comment:
Please note the format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
