Baoyuantop commented on code in PR #3258:
URL: https://github.com/apache/apisix-dashboard/pull/3258#discussion_r2625784531
##########
e2e/tests/plugin_configs.crud-required-fields.spec.ts:
##########
@@ -52,12 +52,13 @@ test('should CRUD plugin config with required fields',
async ({ page }) => {
await pluginConfigsPom.getAddPluginConfigBtn(page).click();
await pluginConfigsPom.isAddPage(page);
- await test.step('cannot submit without required fields', async () => {
- await pluginConfigsPom.getAddBtn(page).click();
- await pluginConfigsPom.isAddPage(page);
- await uiHasToastMsg(page, {
- hasText: 'invalid configuration',
- });
Review Comment:
> an empty plugins object is valid
Could you explain what this means? Some plugins don't have required schema
fields, so they can be created without any configuration, but not all plugins
are like this.
Also, please do not mark the conversation as resolved yourself; this is
usually something the reviewer is required to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
