DSingh0304 commented on code in PR #3258:
URL: https://github.com/apache/apisix-dashboard/pull/3258#discussion_r2626452485
##########
e2e/tests/plugin_configs.crud-required-fields.spec.ts:
##########
@@ -52,12 +52,13 @@ test('should CRUD plugin config with required fields',
async ({ page }) => {
await pluginConfigsPom.getAddPluginConfigBtn(page).click();
await pluginConfigsPom.isAddPage(page);
- await test.step('cannot submit without required fields', async () => {
- await pluginConfigsPom.getAddBtn(page).click();
- await pluginConfigsPom.isAddPage(page);
- await uiHasToastMsg(page, {
- hasText: 'invalid configuration',
- });
Review Comment:
You're absolutely right. I misunderstood the requirement. A PluginConfig
without any plugins isn't semantically valid. I've restored the original
validation test that correctly verifies the "invalid configuration" error
appears when attempting to submit without selecting any plugins. This ensures
the UI properly enforces the business rule that at least one plugin is required.
Also, noted about not resolving conversations myself apologies for that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
