DSingh0304 commented on code in PR #3258:
URL: https://github.com/apache/apisix-dashboard/pull/3258#discussion_r2642152783
##########
src/apis/upstreams.ts:
##########
@@ -55,19 +55,56 @@ export const putUpstreamReq = (
};
export const deleteAllUpstreams = async (req: AxiosInstance) => {
- const totalRes = await getUpstreamListReq(req, {
- page: 1,
- page_size: PAGE_SIZE_MIN,
- });
+ // Retry wrapper to handle potential transient failures (e.g., 500 Internal
Server Error) when fetching upstream list.
+ // This is particularly useful in E2E tests where rapid creation/deletion
might cause temporary instability.
Review Comment:
I've removed the retry wrapper from deleteAllUpstreams() to ensure E2E tests
accurately reflect real-world scenarios without masking failures. Kept only the
404 error handling for cleanup robustness. Tests pass without the retry
mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
