DSingh0304 commented on code in PR #3258:
URL: https://github.com/apache/apisix-dashboard/pull/3258#discussion_r2622016081
##########
e2e/tests/plugin_configs.crud-required-fields.spec.ts:
##########
@@ -52,12 +52,13 @@ test('should CRUD plugin config with required fields',
async ({ page }) => {
await pluginConfigsPom.getAddPluginConfigBtn(page).click();
await pluginConfigsPom.isAddPage(page);
- await test.step('cannot submit without required fields', async () => {
- await pluginConfigsPom.getAddBtn(page).click();
- await pluginConfigsPom.isAddPage(page);
- await uiHasToastMsg(page, {
- hasText: 'invalid configuration',
- });
Review Comment:
I removed these assertions because the client-side schema
(`APISIX.PluginConfig`) actually permits submission with just a `name` (an
empty `plugins` object is valid).
Previously, the test expected an "invalid configuration" error when
submitting without plugins, which was incorrect behavior for the current
schema. I've updated the test to focus on the successful CRUD flow for required
fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
