robocanic commented on code in PR #1565:
URL: https://github.com/apache/dubbo-admin/pull/1565#discussion_r4110553891
##########
release/kubernetes/dubbo-system/dubbo-admin.yaml:
##########
@@ -39,9 +41,15 @@ spec:
serviceAccountName: dubbo-admin
containers:
- name: dubbo-admin
- image: apache/dubbo-admin:0.7.0
- imagePullPolicy: IfNotPresent
- volumeMounts:
+ image: apache/dubbo-admin:0.7.0
+ imagePullPolicy: IfNotPresent
+ env:
Review Comment:
Question: There is no secret defined in the deploy manifests. I think the
secret defined in the ConfigMap is just fined, and if there is need to put it
into secret, you need to bring up a new Secret Resource Definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
