28Hus commented on PR #1565: URL: https://github.com/apache/dubbo-admin/pull/1565#issuecomment-5926866175
> > @robocanic Hello, could you please let us know if this PR of ours can be approved? Feel free to contact me at any time; we are very willing to continue working on Dubbo-admin's security! > > please merge the develop branch and resolve the conflicts @robocanic Thanks for the review. I’ve pushed a follow-up fix and merged the latest develop branch. Copilot’s image finding was valid: injecting a Secret does not fix the published 0.7.0 image. Until an official image containing this fix is available, deploy.sh now requires an explicit image built from the fixed source. It rejects a missing image, 0.7.0, and latest before changing the cluster, then renders the supplied image into the Deployment before applying it. The README also warns against directly applying the manifest, which would bypass this check. I tested the flow locally in Kind with an image built from this PR. The Deployment used the supplied image, the generated Secret remained stable across redeployments, valid login and session requests succeeded, and unauthenticated or invalid-cookie requests returned 401. go test ./... also passes. Once a fixed official image is published, the deployment can use that image as its safe default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
