Copilot commented on code in PR #1565:
URL: https://github.com/apache/dubbo-admin/pull/1565#discussion_r4142069937
##########
release/kubernetes/dubbo-system/dubbo-admin.yaml:
##########
@@ -39,9 +41,15 @@ spec:
serviceAccountName: dubbo-admin
containers:
- name: dubbo-admin
- image: apache/dubbo-admin:0.7.0
- imagePullPolicy: IfNotPresent
- volumeMounts:
+ image: apache/dubbo-admin:0.7.0
Review Comment:
The deployment still pins `0.7.0`, which the new README explicitly states
ignores this environment injection and retains the vulnerable cookie-signing
behavior. Consequently, the documented `deploy.sh` path generates a strong
Secret but deploys an image that does not use it, so Kubernetes users remain
exposed. Pin this manifest to the first image built with this fix (or require
an explicit fixed image) before presenting this as the secure deployment path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
