28Hus commented on code in PR #1565:
URL: https://github.com/apache/dubbo-admin/pull/1565#discussion_r4119506241
##########
release/kubernetes/dubbo-system/dubbo-admin.yaml:
##########
@@ -39,9 +41,15 @@ spec:
serviceAccountName: dubbo-admin
containers:
- name: dubbo-admin
- image: apache/dubbo-admin:0.7.0
- imagePullPolicy: IfNotPresent
- volumeMounts:
+ image: apache/dubbo-admin:0.7.0
+ imagePullPolicy: IfNotPresent
+ env:
Review Comment:
Thanks for the feedback. I pushed a one-command Kubernetes deployment flow:
./release/kubernetes/dubbo-system/deploy.sh. It generates a unique session
signing Secret on first install, preserves it across redeployments, rejects an
invalid existing Secret, and applies the manifests.
I verified fresh installation and redeployment in a local Kind cluster using
an image built from this PR. The services became ready, authentication behaved
as expected, and go test ./... passes.
The published apache/dubbo-admin:0.7.0 image does not contain this fix. The
manifest must be updated to a newly published fixed image before this
deployment flow is recommended to users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
