robocanic commented on code in PR #1565:
URL: https://github.com/apache/dubbo-admin/pull/1565#discussion_r4113691926
##########
release/kubernetes/dubbo-system/dubbo-admin.yaml:
##########
@@ -39,9 +41,15 @@ spec:
serviceAccountName: dubbo-admin
containers:
- name: dubbo-admin
- image: apache/dubbo-admin:0.7.0
- imagePullPolicy: IfNotPresent
- volumeMounts:
+ image: apache/dubbo-admin:0.7.0
+ imagePullPolicy: IfNotPresent
+ env:
Review Comment:
> we could later implement a feature that generates a strong, random key if
the secret is missing from the YAML file.
Agree with that. The manifests in the directory is a one-stop deployment
solution, so can you provide a solution more smoothly?
##########
release/kubernetes/dubbo-system/dubbo-admin.yaml:
##########
@@ -39,9 +41,15 @@ spec:
serviceAccountName: dubbo-admin
containers:
- name: dubbo-admin
- image: apache/dubbo-admin:0.7.0
- imagePullPolicy: IfNotPresent
- volumeMounts:
+ image: apache/dubbo-admin:0.7.0
+ imagePullPolicy: IfNotPresent
+ env:
Review Comment:
> we could later implement a feature that generates a strong, random key if
the secret is missing from the YAML file.
Agree with that. The manifests in the directory is a one-stop deployment
solution, so can you provide a solution more smoothly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
