DonalEvans commented on a change in pull request #6351:
URL: https://github.com/apache/geode/pull/6351#discussion_r627739426
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
##########
@@ -1124,6 +1125,14 @@ public void setQueryConfigurationServiceCreation(
this.queryConfigurationServiceCreation = queryConfigurationServiceCreation;
}
+ @Override
+ public boolean hasMemberOlderThan(KnownVersion version) {
+ return getMembers().stream()
Review comment:
My apologies for not noticing this the first time around, but it seems
like many other methods in CacheCreation throw an UnsupportedOperationException
when called if it doesn't really make sense to call them on a Cache that's in
the process of being created. I think this method should probably follow the
same approach, as it doesn't seem like we're able to actually say whether the
value returned is correct or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
