DonalEvans commented on a change in pull request #6351:
URL: https://github.com/apache/geode/pull/6351#discussion_r627707193
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
##########
@@ -1115,6 +1116,11 @@ public void unlockDiskStore(String diskStoreName) {
}
+ @Override
+ public boolean hasMemberOlderThan(KnownVersion version) {
+ return false;
Review comment:
I wonder if, for this method, it would make sense to follow the approach
used elsewhere in this class where we throw an UnsupportedOperationException
rather than returning an effectively meaningless value. I think that there's no
scenario in which it would make sense to call this method on a `CacheCreation`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
