rpuch commented on code in PR #1246:
URL: https://github.com/apache/ignite-3/pull/1246#discussion_r1006529401
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/outgoing/OutgoingSnapshot.java:
##########
@@ -332,15 +361,15 @@ public boolean addRowIdToSkip(RowId rowId) {
/**
* Returns {@code true} if the given {@link RowId} does not interfere with
the rows that this snapshot is going
- * to be sent in the normal snapshot rows sending order.
+ * to send in the normal snapshot rows sending order.
*
- * <p>Must be called under snapshot lock.
+ * <p>Must be called under MV data snapshot lock.
*
* @param rowId RowId.
* @return {@code true} if the given RowId is already passed by the
snapshot in normal rows sending order.
*/
public boolean alreadyPassed(RowId rowId) {
- if (!startedToReadPartition) {
+ if (!startedToReadMvPartition) {
Review Comment:
Such a banning should probably be made in a separate PR. Should a create a
Jira issue and put a TODO here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
