rpuch commented on code in PR #1246:
URL: https://github.com/apache/ignite-3/pull/1246#discussion_r1006532348
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/outgoing/OutgoingSnapshotReader.java:
##########
@@ -56,13 +56,9 @@ public OutgoingSnapshotReader(PartitionSnapshotStorage
snapshotStorage) {
.learnersList(snapshotStorage.startupSnapshotMeta().learnersList())
.build();
- OutgoingSnapshot outgoingSnapshot = new OutgoingSnapshot(
- id,
- snapshotStorage.partition(),
- snapshotStorage.outgoingSnapshotsManager()
- );
+ OutgoingSnapshot outgoingSnapshot = new OutgoingSnapshot(id,
snapshotStorage.partition());
-
snapshotStorage.outgoingSnapshotsManager().registerOutgoingSnapshot(id,
outgoingSnapshot);
+ snapshotStorage.outgoingSnapshotsManager().startOutgoingSnapshot(id,
outgoingSnapshot);
Review Comment:
42. The understanding (at least, mine) is constantly deepening and changing,
I reflact it in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
