rpuch commented on code in PR #1246:
URL: https://github.com/apache/ignite-3/pull/1246#discussion_r1006534980
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/outgoing/OutgoingSnapshotsManager.java:
##########
@@ -103,17 +103,17 @@ public void stop() throws Exception {
}
/**
- * Registers an outgoing snapshot in the manager.
+ * Starts an outgoing snapshot and registers it in the manager. This is
the point where snapshot is 'taken',
+ * that is, the immutable scope of the snapshot (what MV data and what TX
data belongs to it) is cut.
*
* @param snapshotId Snapshot id.
* @param outgoingSnapshot Outgoing snapshot.
*/
- @Override
- public void registerOutgoingSnapshot(UUID snapshotId, OutgoingSnapshot
outgoingSnapshot) {
+ void startOutgoingSnapshot(UUID snapshotId, OutgoingSnapshot
outgoingSnapshot) {
snapshots.put(snapshotId, outgoingSnapshot);
PartitionSnapshotsImpl partitionSnapshots =
getPartitionSnapshots(outgoingSnapshot.partitionKey());
Review Comment:
Original code (written by you) was using concrete type. I added an interface
(for registering/unregistering), it seemed useful because it was both used by
prod code and mocked in tests. But now, after refactorings, it turned out that
the interface is not needed *here*, so I removed it.
If you still like the interface, let me know, I will restore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
