ibessonov commented on code in PR #1246:
URL: https://github.com/apache/ignite-3/pull/1246#discussion_r1006732355
##########
modules/core/src/main/java/org/apache/ignite/internal/lock/ReusableLockLockup.java:
##########
@@ -29,15 +29,20 @@
public class ReusableLockLockup implements AutoLockup {
private final Lock lock;
- public ReusableLockLockup(Lock lock) {
+ private ReusableLockLockup(Lock lock) {
this.lock = lock;
}
+ public static ReusableLockLockup forLock(Lock lock) {
Review Comment:
I think that constructor implies wrapping, not changing of the state.
Usually constructors don't do anything other than setting fields, especially in
a class as simple as this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
