rpuch commented on code in PR #1246:
URL: https://github.com/apache/ignite-3/pull/1246#discussion_r1006531276
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/outgoing/OutgoingSnapshot.java:
##########
@@ -360,4 +389,15 @@ public boolean alreadyPassed(RowId rowId) {
public void enqueueForSending(RowId rowId) {
outOfOrderMvData.add(rowEntry(rowId));
}
+
+ /**
+ * Closes the snapshot releasing the underlying resources.
+ */
+ public void close() {
+ Cursor<IgniteBiTuple<UUID, TxMeta>> txCursor = txDataCursor;
+
+ if (txCursor != null) {
+ closeQuietly(txCursor);
+ }
Review Comment:
Better safe than sorry. `close()` will be called from a thread different
from those that send the data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
