linghengqian commented on code in PR #32389:
URL: https://github.com/apache/shardingsphere/pull/32389#discussion_r1703969434
##########
parser/sql/dialect/doris/pom.xml:
##########
@@ -36,5 +36,11 @@
<artifactId>shardingsphere-infra-database-doris</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
+ <scope>test</scope>
Review Comment:
- This is actually what I asked you at
https://github.com/apache/shardingsphere/pull/32389#discussion_r1703174856 . We
have 2 options, one is to keep the test scope Logback globally, the other is to
remove the test scope Logback globally. We can of course limit unit tests to
use only Logback. If you think the test scope Log should be kept globally,
another commit will be pushed.
```xml
<dependency>
<groupId>org.apache.hive</groupId>
<artifactId>hive-jdbc</artifactId>
<version>4.0.0</version>
</dependency>
<!-- See https://issues.apache.org/jira/browse/HIVE-28308 -->
<dependency>
<groupId>org.apache.hive</groupId>
<artifactId>hive-service</artifactId>
<version>4.0.0</version>
<exclusions>
<!-- See https://issues.apache.org/jira/browse/HIVE-28429 -->
<exclusion>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client-api</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
</exclusion>
<exclusion>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client-api</artifactId>
<version>3.3.6</version>
</dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
