linghengqian commented on code in PR #32389:
URL: https://github.com/apache/shardingsphere/pull/32389#discussion_r1703857170
##########
parser/sql/dialect/doris/pom.xml:
##########
@@ -36,5 +36,11 @@
<artifactId>shardingsphere-infra-database-doris</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
+ <scope>test</scope>
Review Comment:
- For the current PR, this involves 3 steps.
- Step 1, remove Logback under `pom.xml`, and add provided scope Logback
for modules that directly use the Logback Java API.
- Step 2, globally search for `.xml` files containing `logback` text under
the `**/main/**` directory in the project, and ensure that provided scope
Logback already exists in the corresponding module.
- Step 3, globally match `.xml` files containing logback text under the
`**/test/**` directory in the project, and ensure that test scope Logback
already exists in the corresponding module.
- I would say that the logback community doesn't seem to provide any cli
tools or AI tools to simplify this seemingly weird process. This process is
carried out through the Find window of IntelliJ IDEA 2024.1. On the
shardingsphere side, it looks like we only configure Logback via Java API and
xml, there is no `logback.properties` or `logback.yaml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
