RaigorJiang commented on code in PR #32389:
URL: https://github.com/apache/shardingsphere/pull/32389#discussion_r1703994181
##########
parser/sql/dialect/doris/pom.xml:
##########
@@ -36,5 +36,11 @@
<artifactId>shardingsphere-infra-database-doris</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
+ <scope>test</scope>
Review Comment:
> * This is actually what I asked you at [Block
`shardingsphere-logging-core` from passing `logback-classic` dependencies to
downstream modules #32389
(comment)](https://github.com/apache/shardingsphere/pull/32389#discussion_r1703174856)
. We have 2 options, one is to keep the test scope Logback globally, the other
is to remove the test scope Logback globally. We can of course limit unit tests
to use only Logback. If you think the test scope Log should be kept globally,
another commit will be pushed.
>
Sorry, I misunderstood your intention. I thought we were going to remove the
logback dependency introduced by the logging rule.
For scenarios like hive, the \<exclusion> method is more acceptable, and
ShardingSphere developers can still focus on logback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
