RaigorJiang commented on code in PR #32389:
URL: https://github.com/apache/shardingsphere/pull/32389#discussion_r1703914408
##########
parser/sql/dialect/doris/pom.xml:
##########
@@ -36,5 +36,11 @@
<artifactId>shardingsphere-infra-database-doris</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
+ <scope>test</scope>
Review Comment:
> Yes. Because if we do not exclude the test scope logback globally, after a
module introduces Hiveserver2 JDBC Driver, multiple slf4j adapters including
Reload4j, Log4j2, Logback, Jakarta Commons Logging, etc. will still appear in
the classpath of the unit test at the same time, which violates
https://www.slf4j.org/codes.html#multiple_bindings . I think a better solution
is to explicitly declare Logback in the module that needs to use Logback. What
do you think?
If we use <exclusion> to exclude incompatible dependencies when introducing
new dependency, such as log4j introduced by hive, to ensure the simplicity of
ShardingSphere itself, is this possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
