ccxxxyy commented on PR #37831:
URL: https://github.com/apache/shardingsphere/pull/37831#issuecomment-3825024269
@terrymanu Hello, I have made the requested changes, and the current code
has been verified one by one against your requirements. I would greatly
appreciate it if you could review it when you have some time. Below is a
detailed explanation:
1. **SQLVisitorRule.java, line 218:**
**DORIS_DROP_MATERIALIZED_VIEW("DropMaterializedView",
SQLStatementType.DDL)**
There is no DropMaterializesView.
2. **SQLVisitorRule.java, line 216:**
**DORIS_ALTER_MATERIALIZED_VIEW("DorisAlterMaterializedView",
SQLStatementType.DDL)**
This line of code has been present from the very beginning.
3. **SQLVisitorRule.java, line 234:**
**DORIS_SHOW_VIEW("ShowView", SQLStatementType.DAL)**
It has been renamed to DORIS_SHOW_VIEW as requested.
All three items above comply with the requirement that “names must match
their parser contexts.” As shown in the latest version of the file, I have also
checked the visitor method signatures one by one. There are no “naming
mismatches (rule vs. Context)”, and there are no missing rules or naming errors.
4. **finished**: “Run the parser ITs for Doris/ALL cases to verify no
SQLASTVisitorException remains.”
All test cases pass successfully with no issues. The execution results are
shown in the attached output.
5. **finished**: “Document in the PR that this is parser-only support (no
execution) and list the verification scope.”
In the PR description, I have explained the grammar improvements covered by
this PR and clearly documented the Scope and Limitations.
I hope the explanations above meet your requirements. I sincerely look
forward to your review, and thank you very much for your time, effort, and help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
