nassirsultan opened a new pull request, #38855: URL: https://github.com/apache/shardingsphere/pull/38855
Resolves issue where ShardingSphere-JDBC fails with TableNotExistsException when connecting to MySQL via a JDBC URL with no schema specified. getDatabaseName() checked catalog with "".equals(...), which doesn't catch a null catalog (returned by MySQL's getCatalog() when no schema is set), causing the cached-database-name fallback to be skipped. Replaced the check with Guava's Strings.isNullOrEmpty(), consistent with existing usage elsewhere in the same file. Added a regression test (null catalog fallback case) to MySQLMetaDataLoaderTest, verified to fail without this fix. Fixes #28469 Changes proposed in this pull request: - Fix null-catalog handling in MySQLMetaDataLoader.getDatabaseName() - Add a parameterized test case covering the null-catalog fallback in MySQLMetaDataLoaderTest Before committing this PR, I'm sure that I have checked the following options: - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project. - [x] I have self-reviewed the commit code. - [ ] I have (or in comment I request) added corresponding labels for the pull request. - [ ] I have passed maven check locally: `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e` - [ ] I have made corresponding changes to the documentation. - [x] I have added corresponding unit tests for my changes. - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
