nassirsultan commented on PR #38855: URL: https://github.com/apache/shardingsphere/pull/38855#issuecomment-4741950904
Thanks for the detailed review — pushed a fix for the empty-tableNames crash, with a regression test verified to fail without it (NoSuchElementException) and pass with it. On the remaining point: I went back through the original issue and the linked triage comment, and both describe a single named table failing under the masking feature with no schema selected - I don't see a cross-schema scenario mentioned anywhere in either. My read is that this PR fully resolves what #28469 actually describes, and "cross-schema" might be pointing at a separate, broader concern (e.g. schema handling across multiple sharded data sources) that wasn't part of the original report. Happy to be corrected if I'm missing something, but wanted to flag that distinction rather than assume. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
