nassirsultan commented on PR #38855: URL: https://github.com/apache/shardingsphere/pull/38855#issuecomment-4749175789
Thanks for clarifying — that's a fair distinction, and I want to make sure we're aligned on scope before going further. What this PR does: fixes the null-vs-empty-string mismatch that breaks masking for a specific, named table when no schema is selected (the exact scenario in the original report and the linked triage comment), and closes the empty-tableNames crash that surfaced as a side effect of the first fix. What this PR does not do: implement schema discovery across multiple/all schemas when no schema is selected and no specific table is requested. That's a meaningfully different capability - querying across every schema on the server rather than failing gracefully when none is selected - and I don't see it described in #28469's original report or the linked fix recommendation. If that broader multi-schema discovery is something the project wants, I'd suggest it become its own tracked issue, since it's a real feature with its own design questions (which schemas to query, how to handle naming collisions across them, etc.) rather than a regression test we can bolt onto this fix. For this PR, I'd like to change the description from "Fixes #28469" to "Addresses #28469" to reflect that scope honestly, and treat full multi-schema discovery as a separate follow-up issue. Does that line up with how you'd scope it, or is there something specific in the current code that still needs to change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
