terrymanu commented on PR #38855: URL: https://github.com/apache/shardingsphere/pull/38855#issuecomment-4749417318
Thanks for clarifying. I agree that full multi-schema discovery is a broader behavior than the narrow null/empty catalog fallback fixed in this PR. One important point: #28469's original report does mention fetching all schemas and the other-schema case, so this PR should not use a closing keyword for that issue. Please update the PR description from `Fixes #28469` to something like `Partially addresses #28469` or `Addresses part of #28469`, and explicitly mention that full no-current-schema / cross-schema metadata discovery remains out of scope for this PR. After that, we can re-review this PR as a narrow partial fix. If the intention is still to close #28469 in this PR, then the previous request still stands: the PR needs to implement and test the no-current-schema full metadata path and the other-schema/cross-schema behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
