terrymanu commented on PR #38855: URL: https://github.com/apache/shardingsphere/pull/38855#issuecomment-4753264539
Thanks for updating the PR description and clarifying the scope. I agree with the narrowed scope: this PR can be reviewed as a partial fix for the null/empty catalog fallback and the empty `tableNames` crash, while full no-current-schema / cross-schema metadata discovery remains out of scope. One last thing before this can be merged: the commit message still contains `Fixes #28469`. Since #28469 also mentions fetching all schemas and the other-schema case, please reword or squash the commit so the closing keyword becomes something like `Partially addresses #28469` or `Addresses part of #28469`. After that, I think this PR can be re-reviewed as a narrow partial fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
