HhH666-ux commented on PR #40097:
URL: https://github.com/apache/shardingsphere/pull/40097#issuecomment-6445005503
Check status on `df6d6aeb`, for the record:
Green: `Check - Spotless`, `Check - CheckStyle`, `Check - License`, `CI`
(7/7 in `OpenTelemetryJDBCExecutorCallbackAdviceTest`), `Build E2E Image`, `E2E
- Agent` (all 6 MySQL combinations), `E2E - Operation`, `E2E - SQL`, `Required
- Check`.
The one red check is `CI - GraalVM`, and it is not caused by this change:
- `shardingsphere-agent-tracing-opentelemetry` reports `SUCCESS [7.562 s]`
in that same run, so the module compiles and passes there too.
- The only failing module is `shardingsphere-test-native`, and the only
failing test is
`org.apache.shardingsphere.test.natived.jdbc.databases.ClickHouseTest.assertShardingInLocalTransactions()`
— 23 native tests ran, 22 passed, and testcontainers reported `24 containers
successful, 0 containers failed`, so the containers started fine and the
ClickHouse data assertion inside `processSuccessInClickHouse` came back false.
- That is the ClickHouse Server / ClickHouse Keeper native-image flakiness
this file has had before: #34333 ("this unit test failed frequently", fixed by
adding a Keeper health check) and the still-open #38857, which lists
`ClickHouseTest` among the affected native tests.
Nothing in the diff reaches that code path — the change touches only
`agent/plugins/tracing/type/opentelemetry`, which is not on the native test
classpath.
I cannot rerun the workflow myself (no admin rights on the repository), so
if you want the check green before merging, rerunning the failed job should be
enough. I will keep an eye on this branch in case anything else comes back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
