HhH666-ux commented on PR #40097: URL: https://github.com/apache/shardingsphere/pull/40097#issuecomment-6688990732
Thanks @terrymanu, all three findings from the 2026-11-05 review are addressed in 71cdff4. 1. The enablement check no longer scans the registry. `PENDING_SPANS` is still keyed by execution unit, but the count is now a `ThreadLocal<Integer>` raised in `recordExecuteInfo` and lowered by the single completion exit, `afterMethod`. `isPluginEnabled()` reads only that per-thread count, so pending spans owned by other threads never add work to a later SQL execution. 2. `isPluginEnabled()` now carries `@HighFrequencyInvocation`. 3. `setPluginEnabled` was moved to directly follow its first caller, `assertSpanEndsWhenPluginDisabledDuringExecution`. Nested invocation and exception completion are unchanged: `onThrowing` only records the throwable, and `afterMethod` ends the span with the recorded status. CI is green on 71cdff4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
