HhH666-ux commented on PR #40097: URL: https://github.com/apache/shardingsphere/pull/40097#issuecomment-6458819929
Correction to my previous message — I listed the checks as fully green and that was too broad. `CI - GraalVM` is red on `df6d6aeb`: https://github.com/apache/shardingsphere/actions/runs/40516234651/job/122233495882 The failing case is `ClickHouseTest.assertShardingInLocalTransactions()` in `shardingsphere-test-native` — `AssertionFailedError: expected: <true> but was: <false>`. This PR only touches `shardingsphere-agent-plugin-tracing-opentelemetry` (the JDBC executor callback advice and its test), so I do not see a path from that change into a ClickHouse native sharding transaction test. For signal quality on that job: the same workflow also failed on `master` scheduled runs on 2026-10-19, 2026-10-20 and 2026-10-22, then passed on 10-23, 10-25, 10-26 and 10-27. Everything else on `df6d6aeb` is green: `Check - Spotless`, `Check - CheckStyle`, `Check - License`, `CI` (7/7 in `OpenTelemetryJDBCExecutorCallbackAdviceTest`), `Build E2E Image`, and all six `E2E - Agent with MySQL` combinations. On the review itself: the 2026-10-26 report points at `a77c3d10`, and head has since moved to `df6d6aeb`, which reworks all three P2 items — the `WeakHashMap` registry is now a deadline-reclaimed `ConcurrentHashMap` that does not depend on later map access, the fixed 500 ms GC window is gone, and `setAccessible` / direct `Field.get` are replaced. When you have a moment, a re-read of `df6d6aeb` would tell us whether that direction is acceptable or whether you would prefer a different shape for the reclamation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
