HhH666-ux commented on PR #40097: URL: https://github.com/apache/shardingsphere/pull/40097#issuecomment-6567094730
Quick scope question before I push another revision. Six rounds in, every blocking finding has landed in the reclamation layer — generation tracking, deadline versus sampling, disabled-to-re-enabled transitions. `fe2402b1` (31 Oct) removed that layer entirely: no reclaimer, no enablement generation, no scheduler. What remains is invocation matching — a span is registered under its own `JDBCExecutionUnit` and completion resolves by that key instead of the shared callback attachment. That is the overlapping-invocation defect from #39765, and it is the part I can actually prove. Your review at 02:50 on 31 Oct predates that commit, and all three of its blockers were about the reclaimer, so I'd rather ask than guess whether it still applies. **What is the minimal scope you would merge here?** 1. Current HEAD — invocation-keyed registry plus centralized completion, no reclamation at all. An abandoned entry stays until JVM shutdown, which is the behaviour on `master` today. 2. Only the exception path — keep the callback attachment as-is, just stop double-completing spans on exceptions. 3. Nothing in this file — move the lifecycle question into its own issue and land a one-line fix instead. If the answer is 3 I'd rather do that than keep growing a change nobody wants to merge. If it's 1 or 2, say which and I'll cut the PR down to exactly that and drop the rest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
