HhH666-ux commented on PR #40097: URL: https://github.com/apache/shardingsphere/pull/40097#issuecomment-6518577862
Pushed `3404294`, which closes the four rule findings. The diff is visibility, one line break, one assertion and three local names — no behavior change. **3. Internal cleanup exposed publicly.** `endAbandonedSpans()` is now visible to the package. Its only production reference has always been the scheduler of this class, and the regression sits in `...opentelemetry.advice`, so nothing outside that package can reach it any more. The periodic task runs on a 30-second fixed delay, so a unit test cannot wait for a tick; the regression drives the reclaimer directly, and the end-to-end path stays covered through the plugin lifecycle entry point in `assertPendingSpanIsReleasedWhenPluginStops`. **4. Empty-collection assertion.** `assertThat(..., size(), is(0))` is now `assertTrue(testExporter.getFinishedSpanItems().isEmpty())`. **5. Scheduler wrap.** The first three complete arguments stay on the first line and the break moved before `TimeUnit.MILLISECONDS`; the line is 190 characters against the limit of 200. **6. `actual` prefix.** The three observation locals in `assertMethod`, `assertMethodWithoutParentSpan` and `assertExceptionHandle` are `actualSpanItems`. Verified on `3404294`: - `./mvnw -pl agent/plugins/tracing/type/opentelemetry -Pcheck spotless:check` — exit 0, 11 files clean, none changed. - `./mvnw -pl agent/plugins/tracing/type/opentelemetry -Pcheck checkstyle:check` — 0 violations. - `OpenTelemetryJDBCExecutorCallbackAdviceTest` — 8/8 pass. Findings 1 and 2 are behavioral and untouched by this commit; they stay open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
