[GitHub] [skywalking-rust] jmjoy commented on a diff in pull request #20: Fix time and parent span id.

[GitBox]

jmjoy commented on code in PR #20:
URL: https://github.com/apache/skywalking-rust/pull/20#discussion_r889768917


##########
src/context/trace_context.rs:
##########
@@ -259,6 +264,7 @@ impl TracingContext {
 
         let mut span = Box::new(Span::new(
             self.next_span_id,
+            -1,

Review Comment:
   What is the mean of unfinished span? I think the left is correct, and right 
is incorrect.
   
   | Left      | Right |
   | ----------- | ----------- |
   | 
![image](https://user-images.githubusercontent.com/8677974/172079994-b2143e6f-effe-40f9-8545-82e3600a9bf5.png)
      | 
![image](https://user-images.githubusercontent.com/8677974/172080009-6375f402-3278-413e-8565-b40882e66df9.png)
       |
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org