wu-sheng commented on code in PR #20:
URL: https://github.com/apache/skywalking-rust/pull/20#discussion_r894595455
##########
src/context/trace_context.rs:
##########
@@ -259,6 +264,7 @@ impl TracingContext {
let mut span = Box::new(Span::new(
self.next_span_id,
+ -1,
Review Comment:
If `/status/500` fails, and retry `/status/400` again, then yes, the right
is correct.
But this example seems not relative to why hardcode parent span ID? The
right logic is, `parent span ID` should be the latest unfinished span ID in
this context/thread.
I don't mean the original codes are correct, I don't check so carefully. But
the new one seems not correct at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
