jmjoy commented on code in PR #20:
URL: https://github.com/apache/skywalking-rust/pull/20#discussion_r894602414


##########
src/context/trace_context.rs:
##########
@@ -259,6 +264,7 @@ impl TracingContext {
 
         let mut span = Box::new(Span::new(
             self.next_span_id,
+            -1,

Review Comment:
   I think I understand what you mean. In this case, the parent span ID should 
be set to the Span ID of the previous span that has not set end time. The code 
will change a lot.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to