wu-sheng commented on code in PR #20:
URL: https://github.com/apache/skywalking-rust/pull/20#discussion_r894637214


##########
src/context/trace_context.rs:
##########
@@ -259,6 +264,7 @@ impl TracingContext {
 
         let mut span = Box::new(Span::new(
             self.next_span_id,
+            -1,

Review Comment:
   I can see you did a lot of work on making rust-sdk in PHP ecosystem, and 
also helped our php-agent in skyapm org.
   If you are willing to take more responsibility to this repo, this would be a 
very good start.
   
   @Shikugawa implemented this for the first time, we have a lot to do to 
polish.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to