jmjoy commented on PR #20: URL: https://github.com/apache/skywalking-rust/pull/20#issuecomment-1153411401
> The new one looks better, one questions Do we expect trace context to only exist in one running thread? Just check, because officially, there are two concepts, (1) snapshot concept for across threads context propagation, and (2) async span mode for a span begins and finishes in two threads in other agent implementations. > > Please fix e2e test. Fixed. 1. Due to the concurrency mechanism of trust, `TracingContext` and `Span` should be modified to support multi threading. I think they should be modified in the next issue. 2. There is no mechanism to ensure that the user calls `finalize_span`, I think it is better to implement `Drop` trait automatic call instead, and it can also be modified in the next issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
