LinuxSuRen commented on code in PR #103:
URL: https://github.com/apache/skywalking-go/pull/103#discussion_r1335566830
##########
plugins/grpc/instrument.go:
##########
@@ -67,6 +67,21 @@ func (i *Instrument) Points() []*instrument.Point {
instrument.WithResultType(0, "ClientStream")),
Interceptor: "ClientStreamingInterceptor",
},
+ {
+ PackagePath: "",
+ At: instrument.NewMethodEnhance("*ClientConnInterface",
"Invoke",
Review Comment:
> What do you mean some cases? Do you mean some URL or protocol? Or
something else? You want to compile the agent into your binary, but not using
it?
Yes. Users might only want to install the tool instead of other optional
component. For example my test tool, the following could start a server:
`atest server`
It will output the following errors if no SK server given. I'm thinking
about if it's possible to avoid printing the errors.
`skywalking-go 2023/09/25 14:58:14 open stream error rpc error: code =
Unavailable desc = connection error: desc = "transport: Error while dialing:
dial tcp 0.0.0.0:11800: connect: connection refused"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
