wu-sheng commented on code in PR #103:
URL: https://github.com/apache/skywalking-go/pull/103#discussion_r1335578736
##########
plugins/grpc/instrument.go:
##########
@@ -67,6 +67,21 @@ func (i *Instrument) Points() []*instrument.Point {
instrument.WithResultType(0, "ClientStream")),
Interceptor: "ClientStreamingInterceptor",
},
+ {
+ PackagePath: "",
+ At: instrument.NewMethodEnhance("*ClientConnInterface",
"Invoke",
Review Comment:
In the previous discussion, we were not considering a general use tool would
adopt this agent. So, the old proposal is going to package two binaries, one
with the agent, the other is not. This should be good enough for a business
service.
@mrproliu Do we have the mechanism for the runtime configuration for now? If
so, maybe we could consider add one to disable the agent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
