etr2460 opened a new pull request #16414:
URL: https://github.com/apache/superset/pull/16414


   ### SUMMARY
   https://github.com/apache/superset/pull/16200 updated the add chart page and 
as a side effect started showing virtual datasets in the dropdown. This was 
probably a good thing all told, but at Airbnb we had a bunch of virtual 
datasets with similar names to physical datasets that then made it 
difficult/impossible to find the original physical dataset in the selector.
   
   This change will elevate an exact match dataset name to the top of the 
selector if one exists.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   ![Screen Shot 2021-08-23 at 5 27 33 
PM](https://user-images.githubusercontent.com/7409244/130537008-b69e9509-3e5e-41ce-b2eb-a55dcabebf20.png)
   ![Screen Shot 2021-08-23 at 5 27 44 
PM](https://user-images.githubusercontent.com/7409244/130537010-1ce4ae98-6526-4a10-ae30-770ea7d94ca7.png)
   
   
   ### TESTING INSTRUCTIONS
   created datasets with very similar names, ensured that the one with an exact 
matching name appears first
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue: https://github.com/apache/superset/issues/16173
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   to: @michael-s-molina @ktmud @suddjian 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to