etr2460 commented on a change in pull request #16414:
URL: https://github.com/apache/superset/pull/16414#discussion_r694398626
##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -256,15 +264,12 @@ export default class AddSliceContainer extends
React.PureComponent<
const list: {
label: string;
value: string;
- }[] = response.json.result
- .map((item: Dataset) => ({
- value: `${item.id}__${item.datasource_type}`,
- label: this.newLabel(item),
- labelText: item.table_name,
- }))
- .sort((a: { labelText: string }, b: { labelText: string }) =>
Review comment:
fun fact, this didn't do anything since the selector re-sorts the
options again :P Adding a `filterSort` prop to the selector is how you actually
sort the items in the dropdown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
