ktmud commented on a change in pull request #16414:
URL: https://github.com/apache/superset/pull/16414#discussion_r695041578
##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -194,6 +196,8 @@ export default class AddSliceContainer extends
React.PureComponent<
this.newLabel = this.newLabel.bind(this);
this.loadDatasources = this.loadDatasources.bind(this);
this.handleFilterOption = this.handleFilterOption.bind(this);
Review comment:
I think we should replace both `filterOption` and `filterSort` with
[`match-sorter`](https://github.com/apache/superset/blob/master/superset-frontend/src/explore/components/DatasourcePanel/index.tsx#L203-L223).
It has worked well for the Explore page Dataset side panel.
This basically means controlling the filtering outside of AntD
Select---which should give more consistent filtering behavior across the board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
