michael-s-molina commented on a change in pull request #16414:
URL: https://github.com/apache/superset/pull/16414#discussion_r694734424
##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -256,15 +264,12 @@ export default class AddSliceContainer extends
React.PureComponent<
const list: {
label: string;
value: string;
- }[] = response.json.result
- .map((item: Dataset) => ({
- value: `${item.id}__${item.datasource_type}`,
- label: this.newLabel(item),
- labelText: item.table_name,
- }))
- .sort((a: { labelText: string }, b: { labelText: string }) =>
Review comment:
@etr2460 `filterSort` only sorts when searching. If the user just opens
the select the values will be unsorted if we remove these lines. We'll probably
need to apply your sort function here as well 😉
https://user-images.githubusercontent.com/70410625/130602788-53badf35-a202-4910-840f-2ce71746dabf.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
