etr2460 commented on a change in pull request #16414:
URL: https://github.com/apache/superset/pull/16414#discussion_r695013053
##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -256,15 +264,12 @@ export default class AddSliceContainer extends
React.PureComponent<
const list: {
label: string;
value: string;
- }[] = response.json.result
- .map((item: Dataset) => ({
- value: `${item.id}__${item.datasource_type}`,
- label: this.newLabel(item),
- labelText: item.table_name,
- }))
- .sort((a: { labelText: string }, b: { labelText: string }) =>
Review comment:
hmm, interesting, i didn't even see results rendering when clicking into
the modal without typing anything. although maybe that's because in our env we
have too many datasets so it didn't render fast enough. i'll see what i can do
to fix the sorting for all use cases here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
