stevetracvc commented on code in PR #20353:
URL: https://github.com/apache/superset/pull/20353#discussion_r895694676
##########
superset-frontend/packages/superset-ui-chart-controls/test/utils/getColorFormatters.test.ts:
##########
@@ -133,6 +195,21 @@ describe('getColorFunction()', () => {
expect(colorFunction(100)).toEqual('rgba(255,0,0,1)');
});
+ // it('getColorFunction EQUAL inverse', () => {
Review Comment:
@kasiazjc I don't really like the layout, but that's how it did it when I
used the Checkbox component.
Also, I tried just hiding the checkbox when equals was selected, but ran
into an issue where it wouldn't reappear until one of the between operators was
used (which I'm guessing forced a modal refresh since it added new inputs).
I added the validator, which highlights it in red and won't allow the user
to submit if the checkbox is checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
