stevetracvc commented on code in PR #20353:
URL: https://github.com/apache/superset/pull/20353#discussion_r895702559
##########
superset-frontend/packages/superset-ui-chart-controls/test/utils/getColorFormatters.test.ts:
##########
@@ -133,6 +195,21 @@ describe('getColorFunction()', () => {
expect(colorFunction(100)).toEqual('rgba(255,0,0,1)');
});
+ // it('getColorFunction EQUAL inverse', () => {
Review Comment:
Also, is there a reason it's restricted to just green, red, and yellow? We
have the themes, I'd suggest I add in blue (info), orange (warning), maybe even
gray. And since it just changes the alpha, it kinda seems like the table
designer could just pick their own hex color code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
